Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change baseurl to vault.centos.org for CentOS 8 #1767

Merged
merged 5 commits into from
Feb 3, 2022
Merged

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Feb 1, 2022

What this PR does / why we need it:

[ATTENTION NEEDED] CentOS 8 has reached End-Of-Life (EOL) on January 31st, 2022. It will no longer receive any updates (including security updates). Support for CentOS 8 in KubeOne is deprecated and will be removed in a future release. We strongly recommend migrating to another operating system or CentOS distribution as soon as possible.

CentOS 8 has reached EOL yesterday, and therefore, the base URL for repositories has been changed to vault.centos.org.

Without this change, CentOS 8 nodes cannot be provisioned due to the following error:

sudo yum install -y yum-plugin-versionlock device-mapper-persistent-data lvm2 conntrack-tools ebtables socat iproute-tc rsync
Error: Failed to download metadata for repo 'AppStream': Cannot prepare internal mirrorlist: No URLs in mirrorlist

References:

Does this PR introduce a user-facing change?:

[ATTENTION NEEDED] CentOS 8 has reached End-Of-Life (EOL) on January 31st, 2022. It will no longer receive any updates (including security updates). Support for CentOS 8 in KubeOne is deprecated and will be removed in a future release. We strongly recommend migrating to another operating system or CentOS distribution as soon as possible. 
Change baseurl to vault.centos.org for CentOS 8

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg February 1, 2022 08:12
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Feb 1, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Feb 1, 2022

/retest

pkg/scripts/os_centos.go Outdated Show resolved Hide resolved
pkg/scripts/os_centos.go Show resolved Hide resolved
@xmudrii xmudrii marked this pull request as draft February 2, 2022 11:01
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2022
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii changed the title Change CentOS baseurl to vault.centos.org Change baseurl to vault.centos.org for CentOS 8 Feb 2, 2022
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e4fec6d00e7669b1addb65be5291034dc8f2639

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg marked this pull request as ready for review February 3, 2022 12:20
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2022
@kron4eg
Copy link
Member

kron4eg commented Feb 3, 2022

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f18b90d0b43971add6090a4170191ff97686e17

@kron4eg kron4eg added this to the KubeOne 1.4 milestone Feb 3, 2022
@kubermatic-bot kubermatic-bot merged commit e17b7e0 into master Feb 3, 2022
@kubermatic-bot kubermatic-bot deleted the centos-8-eol branch February 3, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants